Replace pip-compile-based dependency management with uv-based approach#1352
Replace pip-compile-based dependency management with uv-based approach#1352mhucka wants to merge 20 commits into
pip-compile-based dependency management with uv-based approach#1352Conversation
Switch to the use of uv means we don't need this anymore.
The use of uv makes it possible to generate lock files with the necessary version constraints automatically; we don't have to figure them out manually.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the dependency compilation process from a Docker-based pip-compile setup to a local bash script utilizing uv. It updates the dependency files with Python version markers, regenerates the environment files with hashes, and configures uv in pyproject.toml. The review feedback highlights two key issues: the getopts parser in the new bash script will incorrectly swallow options intended for uv, and a critical lower bound constraint for cirq-core was omitted for Python versions older than 3.11.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request replaces the previous Docker-based pip-compile workflow with a faster, uv-based dependency compilation process. It introduces a new script, dev_tools/requirements/create-env-files.sh, updates dependency requirements with environment markers, regenerates the environment lock files with hashes, and configures uv in pyproject.toml. Feedback on the changes highlights a potential Shellcheck warning (SC2086) in the new shell script due to unquoted variables, with a recommendation to use a Bash array to safely handle optional arguments.
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please see inline comments regarding max_compat files, otherwise LGTM.
Also, if all .env.txt files will be only generated by the uv, consider marking them up with the linguist-generated git attribute like here (can be a separate PR).
| # ~~~~ Generate max_compat files ~~~~ | ||
|
|
||
| uv pip compile "$@" \ | ||
| -o dev_tools/requirements/max_compat/dev.env.txt \ |
There was a problem hiding this comment.
Is this still needed? The output in dev_tools/requirements/max_compat/dev.env.txt is nearly identical to dev_tools/requirements/envs/pytest.env.txt. It appears to be compiled for Python >= 3.12 so the constraints in oldest-versions.txt have no effect.
| uv pip compile "$@" \ | ||
| -o dev_tools/requirements/max_compat/pytest-max-compat.env.txt \ |
There was a problem hiding this comment.
Looks like a duplicate of dev_tools/requirements/max_compat/dev.env.txt.
Please fix or delete.
2 participants
Replace the Docker file and scripts in dev_tools/requirements with a simpler scheme that uses
uv.